Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-878) Fixing install with packages.config - should print out the packages to install #880

Conversation

andmos
Copy link
Contributor

@andmos andmos commented Jul 28, 2016

Trying a fix for #878.

Added a check for *.config files and added logging of the packages involved.
Also logs that we actually install from a *.config file.

Closes #878

@andmos andmos changed the title trying a fix for #878 (GH-878) Fixing install with packages.config - should print out the packages to install Jul 28, 2016
@ferventcoder
Copy link
Member

Hello @andmos - thanks for your contribution!

Please ensure you've read over CONTRIBUTING.md and please fix up your commit messages as directed in that document.

We'll be looking for the two commits to squash to just one commit. The doc also mentions how to push the changes back up to this PR. Thanks!

@ferventcoder
Copy link
Member

Also I noticed GitHub doesn't know how to associate your GH account with your commits. If that is not intentional, you may wish to set your username and user email in your git config :)

@Hammerstad
Copy link

It looks like he has his work mail in his config.

He will need to add that email address to his github account.

@@ -362,6 +362,8 @@
* should not have a successful package result for missing package
* should not have inconclusive package result
* should not have warning package result
* should print out package from config file in message
* should specify config file is beeing used in message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andmos slight typo here. Should this be is being used

@andmos andmos force-pushed the feature/anm-GH-878-print-packages-from-config-file branch 2 times, most recently from 2eca9d4 to d078e5d Compare July 28, 2016 15:52
@andmos
Copy link
Contributor Author

andmos commented Jul 28, 2016

There, I have squashed the commits and added a more explanatory text to the commit message.
Also changed the e-mail in the .gitconfig file, don't know if it helped?

@andmos andmos force-pushed the feature/anm-GH-878-print-packages-from-config-file branch from d078e5d to f4d361c Compare July 28, 2016 17:37
@ferventcoder
Copy link
Member

Also changed the e-mail in the .gitconfig file, don't know if it helped?

image

@andmos andmos force-pushed the feature/anm-GH-878-print-packages-from-config-file branch from f4d361c to ddc35ad Compare July 28, 2016 17:56
…file

Previously when running choco install with a .config file as parameter the
output would say ''Installing the following packages:'' followed by the
path to the .config file. This change prints out that a .config file is
being used, as well as listing the packages set for installation.
@andmos andmos force-pushed the feature/anm-GH-878-print-packages-from-config-file branch from ddc35ad to 2364f3f Compare July 28, 2016 18:05
@andmos
Copy link
Contributor Author

andmos commented Jul 28, 2016

Should be good now!

@bpjohannessen
Copy link

Is this being looked at? I'm about to start writing PowerShell code that solves this issue in my installer script..

@ferventcoder
Copy link
Member

@bpjohannessen Yes. This is planned to go into 0.9.10.4 (vNext).

@ferventcoder
Copy link
Member

@andmos There is only one bit of missing behavior. When the packages.config is not the only package name being passed.

@ferventcoder
Copy link
Member

Merged into stable at 66b0107

@andmos andmos deleted the feature/anm-GH-878-print-packages-from-config-file branch July 18, 2017 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choco install with packages.config should print out the packages to install
5 participants